PEXPlugins / Modifyworld

Restriction plugin for Bukkit. Part of PermissionsEx bundle.
36 stars 38 forks source link

Modifyworld 1.19.2 not detecting fake players #32

Open matejdro opened 12 years ago

matejdro commented 12 years ago

Some mods (like BuildCraft, ComputerCraft etc.) creates fake players, so they can perform actions that can normally be done only by players (placing/breaking blocks etc.).

However, since 1.19.2, modifyworld does not detect those players and they automatically gets denied (even debug mode won't display anything about them).

Everything works fine in 1.19.1, so something was done wrong between those two versions that broke detection for fake players.

Psithief commented 12 years ago

Looks like it would have happened once the move to superperms occurred. This is where it happened: https://github.com/PEXPlugins/Modifyworld/commit/89b084c869245f8f879bc12578da2f80fce83b93/

Bukkit is always going to return false when asked about a player it does not know exists. If you want to go back to the way it was before, you'll have to add/change the PermissionsEx/config.yml node permissions.superperms.strict-mode to true.

https://github.com/PEXPlugins/PermissionsEx/wiki/Plugin-Configuration

However this _will_ cause you to lose every single default permission for every plugin (anything that defaults to everyone in a plugin.yml), so you will need to enter them manually into PEX.

Psithief commented 12 years ago

Alternatively you can ask the people who made Bukkit versions of BuildCraft and ComputerCraft to find a way to register fake players with Bukkit. If that works it may cause further bugs.

RebelNode commented 12 years ago

Actually buildcraft has in it's config an option to force loginevents and joinevents for the fake player, which solves the issue. Other such mods don't have that option (I'm running a Tekkit server with a dozen mods like this).

I did not know that strict-mode fixes this! I was sure I tried that, but somehow it has slipped my tests. Thanks for the tip, I've been using 1.19.1 version because of this and I really need some of the features from never versions (like disabling item crafting for certain item IDs). I don't really mind entering everything into permissions.yml manually, I think I've pretty much done so this far anyway.

Psithief commented 12 years ago

Let me know how that goes.

matejdro commented 12 years ago

We have strict-mode on and it still does not appear bo be working (we have given modifyworld.* permissions and we are testing in worldguard region-free area = conditions that worked before.)

Avasam commented 9 years ago

This is still a thing with 1.19.7 btw (It's happening to me with Railcraft currently). A soon as modifyworld is installed, Railcraft fakeplayers stop working

CourtArtanis commented 9 years ago

@Avasam I am having the same problem with BuildCraft - did you find any workarounds?