Player NPC's seem to take no damage (Example: CombatTag Plugin)

[StoneLegion]

It seems that modify world has a nasty bug when it comes to the damage.deal hook. It seems to detect that your hitting a player but causes not damage and even indicates it fine through the debug but like I said does no damage to the NPC Player.

CombatTag is an amazing plugin when you logoff when you get tagged you can stay logged in lets say 5 minutes and the other player can kill your fake player and loot him.

Here is an example of the debug:

pex user kane_hart toggle debug 19:55:04 [INFO] Debug mode for user Kane_Hart enabled! 19:55:06 [INFO] User Kane_Hart checked for "modifyworld.damage.deal.player.PvpLogger4", "modifyworld.*" found

I also can confirm this is happening to another person and also I removed all plugins but pex/modifyworld/combattag.

Also combat tag works flawless with 20+ plugins as long as modify world is disabled.

[StoneLegion]

This is the commit that seems to have broken the function: https://github.com/PEXPlugins/Modifyworld/commit/89b084c869245f8f879bc12578da2f80fce83b93

[Outfenneced]

I would be happy to work with the developers of PEX in order to help get this remedied. I am currently the developer and manager of Combat Tag.

[t3hk0d3]

@KaneHart Sorry for delay, im bit busy this week.

Does modifyworld tell anything to player with informPlayers: true?

Also check for "modifyworld.damage.take."

[Outfenneced]

Sorry for the delayed response. Currently nothing is told if informPlayers: true. I have both modifyworld.damage.take.* and modifyworld.damage.deal.* enabled.

I'm not really sure where things are wrong. Even with modifyworld.* nothing appears to happen. What I do notice is modifyworld.mobtarget.player. popping up once in a while.

[Outfenneced]

There is currently a pull request: https://github.com/PEXPlugins/Modifyworld/pull/38 This will most likely fix problems that have been occurring. Thank you to Psithief