PEXPlugins / Modifyworld

Restriction plugin for Bukkit. Part of PermissionsEx bundle.
36 stars 38 forks source link

- modifyworld.items.put.<id>.of.<container> have a bug #90

Open RiflemanSD opened 10 years ago

RiflemanSD commented 10 years ago

in class PlayerListeners at method onPlayerInventoryClick(InventoryClickEvent event), u have made a mistake. the check if (event.getCurrentItem() == null) never will return null, because if there is not currentItem it will return a AIR item stack and not a null. That's why the permission node modifyworld.items.put. don't work, but modifyworld.items.take. works.

U can edit the ur code , and change it like my code above perhaps, to check when some1 place a item into the inventory:

InventoryAction act = event.getAction(); InventoryAction act1 = InventoryAction.PLACE_ALL; InventoryAction act2 = InventoryAction.PLACE_ONE; InventoryAction act3 = InventoryAction.PLACE_SOME;

    if (act.compareTo(act1) == 0 || act.compareTo(act2) == 0 || act.compareTo(act3) == 0) {
        action = "put";
        item = event.getCursor();
    } else {
        action = "take";
        item = take;
    }
PikachuEXE commented 9 years ago

See #102