search

PEZ / SketchDistributor

Sketch plugin that distributes selected objects vertically or horizontally with a given spacing
MIT License
354 stars 26 forks source link

Elements switch always swap places #1

Closed runlevelsix closed 9 years ago

runlevelsix commented 9 years ago

I have icons I want to distribute evenly, but every time I run Distributor to distribute horizontally, it swaps or reverses their order. I've only tried it so far with 2 or 3 icons.

It doesn't seem to matter what order I select the icons or if I do it in the artboard or in the sidebar. Is it arranging them based on their name? Or just swapping the order?

PEZ commented 9 years ago

It's supposed to keep the horizontal order. And it actually does that when I try. Can you share a simple Sketch doc where you are experiencing the problem? Then I'll have an easier time figuring out what is going on.

adamdexter commented 9 years ago

I'm having this same issue. Can't seem to figure out what the plugin is using to determine order of elements.

PEZ commented 9 years ago

When distributing horizontally the plugin is using the property frame.left to determine the initial order.

I haven't been able reproduce still. A sample Sketch document would really help in tracking this bug down.

PEZ commented 9 years ago

I spotted a potential source to this bug and have addressed it. Can't tell if it fixes the bug, though, because cannot reproduce. Please test the latest version of the plugin and see if it fixes things. (If you are using Sketch Toolbox, just uninstall and then install again.)

Scott-Fischer commented 9 years ago

I thought I was having the same issue with distributing horizontally until I figured out that it uses the layer hierarchy to determine the order. It seems to start with the bottom layer every time and then places each above layer to the right of the bottom layer. Not sure if this was intentional or not, but you may want to add some dialogue to the plugin prompt if it is.

PEZ commented 9 years ago

@Scott-Fischer: Thanks! That is the bug. Now I can reproduce it. And hopefully fix it too. =)