search

PEZ / SketchSeparateShapes

A Sketch-app plugin that does a ”boolean” separate operation on two selected shapes. Like divide in Pathfinder in Adobe Illustrator.
164 stars 10 forks source link

can not work in the latest sketch version #15

Closed Irina1221 closed 5 years ago

Irina1221 commented 5 years ago

sorry, this plugin can not work in the latest sketch version ,any update for it?

PEZ commented 5 years ago

Yes, I'm sorry. I don't know how to fix it yet, but you reminded me to ask for help again: https://sketchplugins.com/d/1007-sketch-52-msshapegroup-shapewithbezierpath-is-not-a-function/5

cjke commented 5 years ago

I've just nudged the bloke that was helping in that thread. Hoping to get some traction.

cjke commented 5 years ago

It looks like they have put through an update. I've not worked with Sketch plugins before (though I do have JS experience) - how are you doing with capacity? I might be able to look at this in a week or two? I just need to get my head around the code base first

PEZ commented 5 years ago

Thanks, @cjke . I'm looking at it again. I think I got most of the functionality back in place again. Let's see if I remember how to publish updates. :smile:

It would be awesome if you had a look at the code. I don't have much time at all maintaining this little plugin. Using an internal ”API” like this really is quite painful.

PEZ commented 5 years ago

Now published a new version. Hoping it will not be too much different from the previous one (when it worked).

cjke commented 5 years ago

1.2.6 works almost flawlessly! That was quick!! The only thing I noticed (and this may have been true for the older one) was that if a shape is fully overlapped it doesn't cut it out of the base shape (it needs to be only partially overlapped to actually seperate it)

cjke commented 5 years ago

Full overlap (doesn't work correctly) Before image

After image

Partial overlap (does work correctly) Before image

After image

PEZ commented 5 years ago

Thanks. This used to work. Can you post it as a separate issue? I'd do it myself, but am out of time (and you have access to the markdown for your nice repro. :smile:)

Closing this for now, as the major breakage is fixed.

cjke commented 5 years ago

Absolutely - will do. Awesome work on fixing it so quickly, and as you said, it covers the major issue

PEZ commented 5 years ago

Well, quickly, I wouldn't say, this has been broken for all too long... Very good with your help in in discovering that silly .layers() that I was somehow missing. I needed that help!

PEZ commented 5 years ago

OK, so I think I have fixed the full overlap problem now. Please give v1.2.7 a spin.

cjke commented 5 years ago

Indeed you have! Awesome mate, great stuff!!