Noise formulas should not contain spaces

PEtab-dev / PEtab

PEtab - an SBML and TSV based data format for parameter estimation problems in systems biology

https://petab.readthedocs.io

MIT License

57 stars 12 forks source link

Noise formulas should not contain spaces #313

Open FFroehlich opened 4 years ago

FFroehlich commented 4 years ago

specifying 'noiseFormula' as 'lambda reg' will make

https://github.com/ICB-DCM/AMICI/blob/16e3d762a94a35d21825f904d9d4381f82d117ab/python/amici/petab_import.py#L502

fail since sp.sympify('lambda reg'). I assume this will be a general issue and is not related to amici and that amici does sufficiently input check the provided petab.

JanHasenauer commented 4 years ago

Is this implemented in the validation? if not, this would be important.