dilpath commented 3 years ago

TODOs

[X] default noise distribution wasn't handled in some cases
[ ] ~~ensure synthetic data file rows are ordered as in the measurements file~~
- should be done by the specific simulator (e.g. AMICI)
[x] add option to ensure synthetic data is non-negative (can become negative after noise is added)

codecov[bot] commented 3 years ago

Codecov Report

Merging #479 (9f4d0e6) into master (d948970) will decrease coverage by 0.03%. The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   78.03%   78.00%   -0.04%     
==========================================
  Files          23       23              
  Lines        2295     2300       +5     
  Branches      544      546       +2     
==========================================
+ Hits         1791     1794       +3     
- Misses        369      370       +1     
- Partials      135      136       +1

Impacted Files	Coverage Δ
petab/simulate.py	`78.84% <71.42%> (-2.01%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d948970...9f4d0e6. Read the comment docs.