codecov[bot] commented 3 years ago

Codecov Report

Merging #492 (2370b11) into develop (d948970) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #492   +/-   ##
========================================
  Coverage    78.03%   78.03%           
========================================
  Files           23       23           
  Lines         2295     2295           
  Branches       544      544           
========================================
  Hits          1791     1791           
  Misses         369      369           
  Partials       135      135

Impacted Files	Coverage Δ
petab/parameters.py	`82.43% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d948970...2370b11. Read the comment docs.

jvanhoefer commented 3 years ago

Hey, sorry for not finishing this up before Christmas.

It seems like @dilpath's bugfix was also the issue in this PR. I added a clarifying sentence in the documentation. To me, this should solve the problems. Are you fine with doing another small release (v.0.1.14), since this issue currently breaks pypesto initial value sampling in the develop branch? (I could take care of that, just want your OK :) )