search

PEtab-dev / libpetab-python

Python package for working with PEtab files
https://libpetab-python.readthedocs.io
MIT License
14 stars 6 forks source link

Generation of condition-specific SBML models #108

Closed dweindl closed 2 years ago

dweindl commented 2 years ago

New function petab.get_model_for_condition to generate condition-specific SBML models based on a PEtab problem.

codecov-commenter commented 2 years ago

Codecov Report

Merging #108 (3c0e5ed) into develop (65fd2da) will increase coverage by 0.19%. The diff coverage is 80.43%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #108      +/-   ##
===========================================
+ Coverage    75.90%   76.10%   +0.19%     
===========================================
  Files           27       27              
  Lines         2976     3021      +45     
  Branches       721      733      +12     
===========================================
+ Hits          2259     2299      +40     
- Misses         535      537       +2     
- Partials       182      185       +3
Impacted Files Coverage Δ
petab/sbml.py 61.95% <80.43%> (+5.84%) :arrow_up:
petab/parameter_mapping.py 71.51% <0.00%> (+2.32%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65fd2da...3c0e5ed. Read the comment docs.

dweindl commented 2 years ago

Looks like compartments in a conditions table aren't yet handled

Oops. Thanks :).

dweindl commented 2 years ago

Another source of initial values is from assignment rules and algebraic rules. [...]

True. It's currently not well defined what should happen in this case (see also discussion in https://github.com/PEtab-dev/PEtab/issues/513). Let's remove all rules targeting overridden entities for now.