search

PEtab-dev / libpetab-python

Python package for working with PEtab files
https://libpetab-python.readthedocs.io
MIT License
14 stars 6 forks source link

Remove deprecated visualization functions #130

Closed dweindl closed 2 years ago

dweindl commented 2 years ago

Remove old visualization functions deprecated since #58.

codecov-commenter commented 2 years ago

Codecov Report

Merging #130 (b2d2b14) into develop (0648b0c) will decrease coverage by 0.55%. The diff coverage is 86.95%.

@@             Coverage Diff             @@
##           develop     #130      +/-   ##
===========================================
- Coverage    77.73%   77.18%   -0.56%     
===========================================
  Files           27       26       -1     
  Lines         2906     2441     -465     
  Branches       718      578     -140     
===========================================
- Hits          2259     1884     -375     
+ Misses         468      404      -64     
+ Partials       179      153      -26
Impacted Files Coverage Δ
petab/visualize/plot_data_and_simulation.py 76.66% <71.42%> (-6.67%) :arrow_down:
petab/visualize/plotting.py 86.05% <91.66%> (+0.04%) :arrow_up:
petab/visualize/__init__.py 100.00% <100.00%> (ø)
petab/visualize/helper_functions.py 78.12% <100.00%> (-4.86%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0648b0c...b2d2b14. Read the comment docs.

dweindl commented 2 years ago

The example notebooks still use the old vis code?! :(

~- [ ] #89~ Will be disabled for now #144