search

PEtab-dev / libpetab-python

Python package for working with PEtab files
https://libpetab-python.readthedocs.io
MIT License
14 stars 6 forks source link

Update first vis example notebook; use non-deprecated functions #137

Closed dweindl closed 2 years ago

dweindl commented 2 years ago

See #89

Also, clear notebook output to not litter the repository - will be run during doc build (#144).

codecov-commenter commented 2 years ago

Codecov Report

Merging #137 (c90fa76) into develop (a463194) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #137   +/-   ##
========================================
  Coverage    77.73%   77.73%           
========================================
  Files           27       27           
  Lines         2906     2906           
  Branches       718      718           
========================================
  Hits          2259     2259           
  Misses         468      468           
  Partials       179      179

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a463194...c90fa76. Read the comment docs.

plakrisenko commented 2 years ago

Only small thing: the plots with an empty VS and with only 'plotId' column aren't the same as stated. In the former case there are three subplots and in the latter case everything is plotted together.

dweindl commented 2 years ago

Only small thing: the plots with an empty VS and with only 'plotId' column aren't the same as stated. In the former case there are three subplots and in the latter case everything is plotted together.

Thanks. Updated.