search

PEtab-dev / libpetab-python

Python package for working with PEtab files
https://libpetab-python.readthedocs.io
MIT License
14 stars 6 forks source link

Fix handling of NaN values for parameters in condition table #150

Closed dweindl closed 2 years ago

dweindl commented 2 years ago

In such cases, the parameter value from the model should be used. So far, NaN was kept.

codecov-commenter commented 2 years ago

Codecov Report

Merging #150 (37c05c4) into develop (44ff4af) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #150      +/-   ##
===========================================
+ Coverage    77.16%   77.20%   +0.03%     
===========================================
  Files           26       26              
  Lines         2439     2443       +4     
  Branches       578      579       +1     
===========================================
+ Hits          1882     1886       +4     
  Misses         404      404              
  Partials       153      153
Impacted Files Coverage Δ
petab/parameter_mapping.py 70.32% <100.00%> (+0.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44ff4af...37c05c4. Read the comment docs.

FFroehlich commented 2 years ago

Is there a petab testsuite case that covers condition tables with NaNs?

dweindl commented 2 years ago

Is there a petab testsuite case that covers condition tables with NaNs?

Yes, but only for species, not for parameters.