search

PEtab-dev / libpetab-python

Python package for working with PEtab files
https://libpetab-python.readthedocs.io
MIT License
14 stars 6 forks source link

xOffset for logscale xValues #17

Open FFroehlich opened 4 years ago

FFroehlich commented 4 years ago

I feel like xOffset should be adapted to the scale that is employed, applying linear offsets on a logscale doesnt work well

simulation_and_datacell_cycle_no_M_washout_ridgeAU565LEE011_Ribocicliblambda10.0.pdf

MerktSimon commented 4 years ago

you mean entries xScale=log10 and xOffset=5 should lead to a "real" offset of 10⁵? Imo writing the linear value in either case would stay in consistency with e.g. the parameter table, where bounds are still written in linear values even if parameters live in log space.