PEtab-dev / libpetab-python

Python package for working with PEtab files
https://libpetab-python.readthedocs.io
MIT License
14 stars 5 forks source link

Update deprecated functions in tests #181

Closed yannikschaelte closed 1 year ago

yannikschaelte commented 1 year ago

I'd argue that when marking arguments as deprecated, tests should proceed to use the new arguments (and optionally keep some tests using the old ones, but only as extras)?

number of test warnings reduced from ~42 to 5

codecov-commenter commented 1 year ago

Codecov Report

Merging #181 (125e099) into develop (7455e03) will decrease coverage by 0.34%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #181      +/-   ##
===========================================
- Coverage    78.06%   77.72%   -0.35%     
===========================================
  Files           29       29              
  Lines         2644     2644              
  Branches       591      591              
===========================================
- Hits          2064     2055       -9     
- Misses         421      431      +10     
+ Partials       159      158       -1     
Impacted Files Coverage Δ
petab/problem.py 64.75% <ø> (-1.92%) :arrow_down:
petab/parameter_mapping.py 65.96% <0.00%> (-2.10%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.