search

PEtab-dev / libpetab-python

Python package for working with PEtab files
https://libpetab-python.readthedocs.io
MIT License
14 stars 5 forks source link

Handle missing nominalValue in Problem.get_x_nominal #223

Closed dweindl closed 11 months ago

dweindl commented 11 months ago

It doesn't seem to be quite clear if the nominalValue column needs to be present if all parameters are estimated. However, since it's allowed to leave nominalValue empty, which is treated as NaN, it seems to make sense to treat a missing nominalValue column as all-NaN.

See also https://github.com/ICB-DCM/pyPESTO/issues/1104

codecov-commenter commented 11 months ago

Codecov Report

Merging #223 (9e52f08) into develop (d9b1e65) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #223      +/-   ##
===========================================
+ Coverage    76.33%   76.35%   +0.02%     
===========================================
  Files           34       34              
  Lines         3173     3176       +3     
  Branches       769      770       +1     
===========================================
+ Hits          2422     2425       +3     
  Misses         552      552              
  Partials       199      199
Files Changed Coverage Δ
petab/problem.py 64.89% <100.00%> (+0.37%) :arrow_up: