search

PEtab-dev / libpetab-python

Python package for working with PEtab files
https://libpetab-python.readthedocs.io
MIT License
14 stars 5 forks source link

Fix accessing preequilibrationConditionId without checking for presence #228

Closed dweindl closed 8 months ago

dweindl commented 9 months ago

Fixes a bug in petab.visualize.data_overview.create_report which fails if there is no preequilibrationConditionId column in the measurements table.

codecov-commenter commented 9 months ago

Codecov Report

Merging #228 (a60ccc7) into develop (2c44efe) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #228      +/-   ##
===========================================
- Coverage    76.24%   76.24%   -0.01%     
===========================================
  Files           34       34              
  Lines         3183     3182       -1     
  Branches       773      773              
===========================================
- Hits          2427     2426       -1     
  Misses         555      555              
  Partials       201      201
Files Changed Coverage Δ
petab/visualize/data_overview.py 96.87% <100.00%> (-0.10%) :arrow_down:
dweindl commented 8 months ago

safer to create the PREEQUILIBRATION_CONDITION_ID key and fill it with dummy values here if it doesn't exist

Yes. That would be something to consider throughout the library. Has been discussed before, but without any clear conclusion (e.g. #27). I will leave it as is for now.