Wrong plot_goodness_of_fit if different order of rows in measurement_df and simulation_df

PEtab-dev / libpetab-python

Python package for working with PEtab files

https://libpetab-python.readthedocs.io

MIT License

14 stars 6 forks source link

Wrong plot_goodness_of_fit if different order of rows in measurement_df and simulation_df #247

Open plakrisenko opened 7 months ago

plakrisenko commented 7 months ago

Currently there is no check in plot_goodness_of_fit that rows in measurement_df and simulation_df correspond to each other. And if they do not it messes up the plot.

For example, for the Isensee model from the benchmark collection

Wrong plot: residuals_vs_simu

Correct plot: residuals_vs_simu

plakrisenko commented 3 months ago

Actually, the second plot was still wrong :smile: residuals_vs_simu