PEtab-dev / libpetab-python

Python package for working with PEtab files
https://libpetab-python.readthedocs.io
MIT License
14 stars 5 forks source link

Add PEtab math parser and sympy converter #260

Closed dweindl closed 1 week ago

dweindl commented 1 month ago

Related to https://github.com/PEtab-dev/PEtab/pull/579

Note: All sympy symbols in PEtab match expressions now have real=True.

dweindl commented 3 weeks ago
codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 74.28256% with 233 lines in your changes missing coverage. Please review.

Project coverage is 75.68%. Comparing base (41481bb) to head (18c59e4).

Files Patch % Lines
petab/math/_generated/PetabMathExprParser.py 73.06% 140 Missing and 34 partials :warning:
petab/math/SympyVisitor.py 69.23% 19 Missing and 21 partials :warning:
...etab/math/_generated/PetabMathExprParserVisitor.py 61.36% 16 Missing and 1 partial :warning:
petab/math/_generated/PetabMathExprLexer.py 96.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #260 +/- ## =========================================== - Coverage 76.12% 75.68% -0.45% =========================================== Files 36 40 +4 Lines 3238 4137 +899 Branches 785 891 +106 =========================================== + Hits 2465 3131 +666 - Misses 568 744 +176 - Partials 205 262 +57 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dweindl commented 1 week ago

I didn't check _generated much.

Good. That's auto-generated and not really meant to be read.