PEtab-dev / libpetab-python

Python package for working with PEtab files
https://libpetab-python.readthedocs.io
MIT License
14 stars 5 forks source link

Deprecate petablint with individual tables #274

Closed dweindl closed 1 week ago

dweindl commented 1 week ago

I think the main use case is running petablint on a full petab problem, so we don't need the option to pass individual tables. To support individual tables with the upcoming petab v2, we'd have to extend the list of files and require a version number. I don't it's worth maintaining this functionality (correct me if I am wrong), since validation of individual files is anyways rather limited.

Therefore, this adds deprecation warnings to command line arguments for individual PEtab tables and for the -y --yaml flags, which are no longer required, and the removal of which will make petablint easier to use.

Related to https://github.com/PEtab-dev/libpetab-python/issues/271

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 76.09%. Comparing base (98951d1) to head (f39e1ea).

Files Patch % Lines
petab/petablint.py 0.00% 20 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #274 +/- ## =========================================== - Coverage 76.30% 76.09% -0.22% =========================================== Files 36 36 Lines 3224 3233 +9 Branches 783 786 +3 =========================================== Hits 2460 2460 - Misses 559 568 +9 Partials 205 205 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.