search

PEtab-dev / libpetab-python

Python package for working with PEtab files
https://libpetab-python.readthedocs.io
MIT License
14 stars 6 forks source link

Ruff pyupgrade: python3.10 #276

Closed dweindl closed 5 months ago

dweindl commented 5 months ago

Auto-modernize code.

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 92.68293% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.30%. Comparing base (e488e56) to head (b6002fc).

Files Patch % Lines
petab/visualize/plot_residuals.py 0.00% 0 Missing and 2 partials :warning:
petab/composite_problem.py 50.00% 1 Missing :warning:
petab/lint.py 75.00% 0 Missing and 1 partial :warning:
petab/visualize/plotting.py 85.71% 0 Missing and 1 partial :warning:
petab/yaml.py 91.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #276 +/- ## =========================================== - Coverage 76.33% 76.30% -0.03% =========================================== Files 36 36 Lines 3228 3224 -4 Branches 783 783 =========================================== - Hits 2464 2460 -4 Misses 559 559 Partials 205 205 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dweindl commented 5 months ago

Where was this implemented? Is it the pyproject.toml file?

The rules were already enabled in pyproject.toml before ("UP",), but neither the target python version or the minimum python requirement of the package were set there.