PEtab-dev / libpetab-python

Python package for working with PEtab files
https://libpetab-python.readthedocs.io
MIT License
14 stars 6 forks source link

Optional relative paths in generated YAML #57

Closed dilpath closed 3 years ago

dilpath commented 3 years ago
codecov-io commented 3 years ago

Codecov Report

Merging #57 (44ef94c) into develop (0917194) will decrease coverage by 0.32%. The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #57      +/-   ##
===========================================
- Coverage    78.71%   78.38%   -0.33%     
===========================================
  Files           24       24              
  Lines         2321     2332      +11     
  Branches       549      551       +2     
===========================================
+ Hits          1827     1828       +1     
- Misses         361      370       +9     
- Partials       133      134       +1     
Impacted Files Coverage Δ
petab/problem.py 71.36% <ø> (ø)
petab/yaml.py 78.08% <16.66%> (-12.25%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0917194...44ef94c. Read the comment docs.

dweindl commented 3 years ago
  • feel free to suggest a better name than yaml_centric

relpath (in line with the respective Python function), relative_paths, relative?

  • not sure if it should default to relative paths when calling petab.Problem.to_files and/or petab.yaml.create_problem_yaml (currently only the former)

I think it makes sense to change the default to True. It's a breaking change, but I wouldn't expect many users to rely on having absolute paths in there.