search

PEtab-dev / libpetab-python

Python package for working with PEtab files
https://libpetab-python.readthedocs.io
MIT License
14 stars 6 forks source link

Unreachable TypeError in `petab.parameter_mapping.apply_overrides_for_observable` #59

Closed FFroehlich closed 3 years ago

FFroehlich commented 3 years ago

I don't think https://github.com/PEtab-dev/libpetab-python/blob/0917194199df10b40e3c16dd567a1fdcda0c08c7/petab/parameter_mapping.py#L365 can ever be reached.

If overridee_id is not present in mapping, the code will simply add a new entry and not throw a KeyError.

yannikschaelte commented 3 years ago

that seems correct, as mapping is just a dict. it should likely check for existence of that key instead.

dweindl commented 3 years ago

Apparently my fault... not sure what I was thinking back then...