search

PEtab-dev / libpetab-python

Python package for working with PEtab files
https://libpetab-python.readthedocs.io
MIT License
14 stars 6 forks source link

Ensure measurements are numeric and not null with linter #76

Closed dilpath closed 2 years ago

dilpath commented 2 years ago

A benchmark model was passing the linter despite having null measurement values (see https://github.com/Benchmarking-Initiative/Benchmark-Models-PEtab/pull/129).

codecov-commenter commented 2 years ago

Codecov Report

Merging #76 (bb065de) into develop (4468248) will decrease coverage by 0.06%. The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #76      +/-   ##
===========================================
- Coverage    79.63%   79.56%   -0.07%     
===========================================
  Files           26       26              
  Lines         2936     2946      +10     
  Branches       693      695       +2     
===========================================
+ Hits          2338     2344       +6     
- Misses         423      425       +2     
- Partials       175      177       +2
Impacted Files Coverage Δ
petab/lint.py 77.10% <60.00%> (-0.54%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4468248...bb065de. Read the comment docs.