search

PEtab-dev / libpetab-python

Python package for working with PEtab files
https://libpetab-python.readthedocs.io
MIT License
14 stars 6 forks source link

allow zero bounds for log parameters #83

Closed FFroehlich closed 2 years ago

FFroehlich commented 2 years ago

if there is no finiteness check for upper bound, I don't see why we should prevent lower bound 0 for log scale parameter, it convenient for specifying unbounded parameters after all.

codecov-commenter commented 2 years ago

Codecov Report

Merging #83 (4a18854) into develop (0a2de3b) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #83   +/-   ##
========================================
  Coverage    79.59%   79.59%           
========================================
  Files           26       26           
  Lines         2940     2940           
  Branches       695      695           
========================================
  Hits          2340     2340           
  Misses         423      423           
  Partials       177      177
Impacted Files Coverage Δ
petab/lint.py 77.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a2de3b...4a18854. Read the comment docs.