search

PEtab-dev / libpetab-python

Python package for working with PEtab files
https://libpetab-python.readthedocs.io
MIT License
14 stars 6 forks source link

Visualization: Don't mess with rcParams #90

Closed dweindl closed 2 years ago

dweindl commented 2 years ago

Setting matplotlib rcParams makes it impossible to use custom styles, and therefore, should best be avoided.

codecov-commenter commented 2 years ago

Codecov Report

Merging #90 (d4cba69) into develop (22a9a0c) will decrease coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #90      +/-   ##
===========================================
- Coverage    79.57%   79.54%   -0.04%     
===========================================
  Files           26       26              
  Lines         2938     2933       -5     
  Branches       695      695              
===========================================
- Hits          2338     2333       -5     
  Misses         423      423              
  Partials       177      177
Impacted Files Coverage Δ
petab/visualize/plotter.py 77.38% <100.00%> (-0.66%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22a9a0c...d4cba69. Read the comment docs.

plakrisenko commented 2 years ago

I guess the appearance is ok with the defaults, but should we also provide some custom styles, e.g. using 'tableau-colorblind10' and one suitable for presentation?

dweindl commented 2 years ago

should we also provide some custom styles, e.g. using 'tableau-colorblind10' and one suitable for presentation?

I would keep the matplotlib defaults and let the user choose their style. The proper style depends on many factors... Fine to use that color palette in the example notebooks.