search

PEtab-dev / petab_select

Model selection for PEtab
https://petab-select.readthedocs.io
BSD 3-Clause "New" or "Revised" License
10 stars 0 forks source link

libpetab version required should be specified. #122

Open fbergmann opened 1 hour ago

fbergmann commented 1 hour ago

@dilpath petab select 0.2.1 will not work without it, antlr4-python3-runtime should be listet as dependency, so it gets automatically installed. Or not required.

dweindl commented 1 hour ago

That should only be a transitive dependency through petab and it's required there, isn't it?

https://github.com/PEtab-dev/petab_select/blob/be0df58546ed490a598362182ac73f7f9bdfa946/pyproject.toml#L23

https://github.com/PEtab-dev/libpetab-python/blob/99373c4340512def5a23bf2a75805c3f88251251/pyproject.toml#L24

fbergmann commented 1 hour ago

mhm, sorry for the noise I had an old version of libpetab, then I change this into the minimum version number for libpetab should be specified.