search

PEtab-dev / petab_select

Repository for development of the model selection extension
https://petab-select.readthedocs.io
BSD 3-Clause "New" or "Revised" License
9 stars 0 forks source link

potential issue with `write_summary_tsv` #37

Closed fbergmann closed 1 year ago

fbergmann commented 1 year ago

in line 272 in ui.py we have 

    # FIXME remove once MostDistantCandidateSpace exists...
    method = candidate_space.method
    if (
        candidate_space.governing_method == Method.FAMOS
        and candidate_space.predecessor_model.predecessor_model_hash is None
    ):

however, the predecessor_model can be either a Model, or str. In the case of str this code will fail with an AttributeError.

dilpath commented 1 year ago

Hi Frank, thanks! Should be fixed in #38 and available here and via PyPI.

fbergmann commented 1 year ago

thanks that fixes this issue.