Closed dilpath closed 8 months ago
Attention: 30 lines
in your changes are missing coverage. Please review.
Comparison is base (
f9a2a87
) 60.95% compared to head (6dae816
) 57.58%.
Files | Patch % | Lines |
---|---|---|
petab_select/ui.py | 5.88% | 16 Missing :warning: |
petab_select/model.py | 9.09% | 10 Missing :warning: |
petab_select/criteria.py | 20.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The FAMoS candidate space returns no models, if one of its inner methods (e.g. the forward method) provides no models. Calibration tools (e.g. pyPESTO) then terminate the model selection, because no models were provided. However, at this point, FAMoS should switch to another method.
This switching is now implemented, in
petab_select/ui.py
.The other changes are to remove the other switching methods (
ForwardAndBackwardCandidateSpace
andBidirectionalCandidateSpace
), because these methods are probably not used by anyone, and would suffer from the same issue currently.StopIteration
s would need to be implemented in them, similarly toFamosCandidateSpace
, when the search should truly terminate.