search

PEtab-dev / petab_select

Repository for development of the model selection extension
https://petab-select.readthedocs.io
BSD 3-Clause "New" or "Revised" License
9 stars 0 forks source link

Fix argument order in `calculate_aicc` #71

Closed dweindl closed 10 months ago

dweindl commented 10 months ago

Fix argument order in calculate_aicc. nllh was used as n_estimated and vice versa when computing AIC.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7c71053) 60.61% compared to head (683a2c1) 60.61%.

Files Patch % Lines
petab_select/criteria.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #71 +/- ## ======================================== Coverage 60.61% 60.61% ======================================== Files 14 14 Lines 1521 1521 ======================================== Hits 922 922 Misses 599 599 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dweindl commented 10 months ago

Still computed correctly, since the order doesn't matter in this case, right?

You are right. Doesn't matter for AIC.

If so, I would rename the PR, to avoid confusion -- previous work doesn't need to be redone with this fix, since results won't change.

Done.