search

PGBI / cakephp3-soft-delete

83 stars 60 forks source link

Customise field #2

Closed davidyell closed 9 years ago

davidyell commented 9 years ago

I am upgrading a Cake2 application which used the CakeDC/Utils plugin SoftDelete behaviour, which means that my fields are not named correctly. Rather than update a field in every table of my application, I've just changed the code to allow the field to be declared in the Table.

PGBI commented 9 years ago

Thanks for this new feature. Could you just add a unit test for it?

davidyell commented 9 years ago

Sure thing, can do that tomorrow.

On Tue, 14 Apr 2015 18:05 Pierre notifications@github.com wrote:

Thanks for this new feature. Could you just add a unit test for it?

Reply to this email directly or view it on GitHub https://github.com/PGBI/cakephp3-soft-delete/pull/2#issuecomment-92982495 .

PGBI commented 9 years ago

Sorry for these late remarks (private attribute + change method name). These will be the last ones :)

davidyell commented 9 years ago

Thanks for merging the changes, are you okay to update the method name please? Sorry I didn't get to it, I was interested in your thoughts on the class property visibility.

PGBI commented 9 years ago

I've updated the method name already. I'm going to vacation, i wanted to merge your pr before leaving !