search

PGBI / cakephp3-soft-delete

83 stars 60 forks source link

fix 'withDeleted' #25

Open ks-ocean opened 7 years ago

ks-ocean commented 7 years ago

use the 'strict' option for 'in_array'

http://php.net/manual/en/function.in-array.php

tuna-rootnet commented 7 years ago

Please merge this fix; I ran into this problem this week, tracked it down to in_array() not using strict mode. If your options contains something like ['some_key' => true], the plugin will not add the $aliasedField . 'IS NULL' to the query and include deleted records in the results, even though 'withDeleted' is not present in the array. Using strict for in_array resolves this problem.