search

PGBuildFarm / server-code

PostgreSQL Build Farm Server
https://buildfarm.postgresql.org
Other
13 stars 11 forks source link

Speed up rendering of status page by placing images via css. #10

Closed anarazel closed 2 years ago

anarazel commented 2 years ago

Only tested on the html output locally (with a regex), so this probably doesn't quite work as-is.

The flag_imgs hash could now be a list, but I didn't know how to do that syntaxwise.

The resulting html could also be significantly reduced in size by just removing a few unnecessary newlines etc...

anarazel commented 2 years ago

For me this makes rendering go from > 4s to < 0.5s in firefox.

adunstan commented 2 years ago

Interesting. I will get comments from my expert in this area.

anarazel commented 2 years ago

FWIW, even if the rendering performance benefits down turn out to be not as large for others, just reducing the size of the status page output due to removing redundant data (alt, height, width) out-of-line seems like a good idea.

adunstan commented 2 years ago

Yeah. My web guru has given it in principal approval, so I will move on it shortly.

adunstan commented 2 years ago

See b463cd429d3e5

anarazel commented 2 years ago

Thanks!

It's nice how snappy the frontpage now feels. And a bit absurd that moving things around like this can have such an impact.