search

PGBuildFarm / server-code

PostgreSQL Build Farm Server
https://buildfarm.postgresql.org
Other
13 stars 11 forks source link

Make cleanfiles.pl check the database #7

Closed sfrost closed 3 years ago

sfrost commented 4 years ago

cleanfiles.pl previously just nuked everything older than a certain age. Instead, have it actually query the database to see if the animal+snapshot has been imported or not. If the animal+snapshot doesn't show up after a while, start complaining.

Checking the database only works for files that are 'animal.timestamp' currently. Other recognized files (tmp.PID.tgz and tmp.PID.unpacklogs) are handled as they previously were- ideally these files would end up changed/renamed to have a similar 'animal.timestamp.something' (or similar) filename to allow them to also be compared against the database.

Hidden files are ignored. A warning is thrown for any other files found but they're left alone.

In passing, add $raw_tables to BuildFarmWeb.pl.skel since it was apparently missed.

sfrost commented 4 years ago

Apologies, I see you did the raw_tables bit differently in the branch, and the way you did it is fine.

I've removed that from the PR.

adunstan commented 3 years ago

we're not on dev/brekka any more. If you thing there's still work to do please submit a PR against master.