search

PGBuildFarm / server-code

PostgreSQL Build Farm Server
https://buildfarm.postgresql.org
Other
13 stars 11 forks source link

Add total time of a test run to output #9

Closed anarazel closed 2 years ago

anarazel commented 2 years ago

Hi,

Given the number of steps a test run has these days adding up the individual steps isn't really feasible anymore. It'd be useful if both show_log.pl and show_history.pl could show the total time of successful runs.

That'd make it much easier to pinpoint when we made regression tests much slower.

Regards,

Andres

adunstan commented 2 years ago

show_log.pl already has the total run time.

I will look at adding it to show_history, but I want to make sure it doesn't slow the history page down.

anarazel commented 2 years ago

show_log.pl already has the total run time.

Oh, great. I somehow didn't see that.

I will look at adding it to show_history, but I want to make sure it doesn't slow the history page down.

Makes sense. I think adding it to build_status_recent_500 should prevent slowdowns - computing SUM(stage_duration) in the trigger should be OK, cost-wise?

adunstan commented 2 years ago

Yep, experimentation shows the history query ran way too slowly. Cacheing it will be the answer as you suggest, but that will take more time to arrange.

adunstan commented 2 years ago

performance seems OK now