PGMDev / PGM

The original PvP Game Manager for Minecraft
https://pgm.dev
GNU Affero General Public License v3.0
185 stars 89 forks source link

Damage-Taken statistic is sometimes super inflated #953

Closed Xerocoles closed 2 years ago

Xerocoles commented 2 years ago

Heyo, so here's a super annoying stat issue that affects both Bolt & Stratus. As someone who's looked through countless Stratus match links of player stats, and had to use them to make tons of calculations, I can say this is 100% happening at times (I'll prove it in a sec) yet it's only very rarely. The vast majority of times, all the statistics seem perfectly fine. Yet every now and then you'll see one that seems suspicious in the Damage-Taken column only, or one where Damage-Taken is just completely obviously way off. Obviously it'll be slightly higher in total than the total Damage-Dealt since there's fall damage and void damage, but that's not what this is about.

Example 1 (https://stratus.network/match/7457043571461) Screen Shot 2022-01-09 at 10 28 35 PM The damage dealt by red team is 1069. The damage taken by blue team is 1726. That means that for this to be true, Blue had to take almost 700 hearts in fall damage and/or void damage on Coven. Well that's just not true, I watched the whole game. If you want some reference, looking at the non-bugged stats of red team, they took a total of 26.5 hearts extra damage, not anything close to 700. So in all likelihood, Blue is also probably in the 20-30 range. I used to think it was commonly just multiplied by x2 perfectly, but these all seem bugged, and if you cut them all in half, you end up way short of the damage-dealt, which is impossible. I tried removing Mamut's cut, since maybe his is legit, but it's still not enough. So clearly it's not JUST a "sometimes becomes x2" issue, even though that often seems reasonable.

Example 2 (https://bolt.rip/matches/d719e2) Screen Shot 2022-01-09 at 10 34 27 PM This is basically just to show that it's also happened on Bolt. Guapote, Hielos, FeyRune, PepeLMAO, Zeus, and TOOOR all appear to be bugged, some of them definitely, (Guapote) and some just probably.

Example 3

Screen Shot 2022-01-09 at 10 42 11 PM

This one is slightly older, not sure the match it's from. Unless it was from somehow taking billions of fall damage hearts like from a staff doing /rocket, it just doesn't make any sense. And I seriously doubt that's the case, the only reason it's a chance is because I don't know the context on this one lol. But anyways, it mainly proves that it can be bugged in many ways, like this one is WAY higher than it should be.

Extra sidenotes:

Pablete1234 commented 2 years ago

This is a bit too much text imo,

TLDR is that the damage taken stat tracked by pgm is sometimes higher than it should, this should be visible in-game on the paper with stats if that's the case so checking websites shouldn't be needed, and you have confirmed that it does happen

Do we know under which conditions this happens?

Xerocoles commented 2 years ago

We have found one clue finally! -- you can apply damage to players while being a spectator, i.e. pulling out a diamond sword and critting someone

KingOfSquares commented 2 years ago

957