PGSSoft / PuzzleMaker

Swift framework responsible for generating puzzles from the image
MIT License
128 stars 24 forks source link

Kellyroach/upgrade to xcode10 #3

Closed kellyroach closed 5 years ago

kellyroach commented 6 years ago

This pull request updates PuzzleMaker to Xcode 10 / Swift 4.2 . Current master branch demo app gets 4 yellow warnings and 2 red build errors in Xcode 10:

4x "using '!' is not allowed here; treating this as '?' instead"
"value of optional type 'PuzzleUnit?' must be unwrapped to a value of type 'PuzzleUnit'"
"cannot convert value of type '@lvalue [[PuzzleElement?]]' to closure result type '[[PuzzleElement]]'"

Our pull request fixes these issues and improves the image size and numColumns / numRows appearance in the demo app a bit.

pwlkania commented 5 years ago

Thank you @kellyroach for your support!