Closed nebfield closed 5 days ago
Attention: Patch coverage is 98.30508%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 89.61%. Comparing base (
15f7095
) to head (1566a89
). Report is 4 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
pgscatalog.core/src/pgscatalog/core/lib/models.py | 94.73% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
When processing a single file, if the combine CLI encountered an invalid variant it would quietly fail to write out any variants (quiet except for a misleading log statement). Some investigation notes:
return
statement inside afinally
block 😬ValidationError
exceptionCloses #55
Test results
22 (older) scoring files contain invalid rsIDs:
Fix is to relax the rsID check when harmonisation goes wrong. No other
ValidationErrors
get thrown.