search

PHACDataHub / cpho-phase2

A data collection and retrieval application to automate and standardize the data intake for the yearly Health of Canadians report
5 stars 3 forks source link

feat: deprecate redirects from data-donnes #385

Closed vedantthapa closed 2 months ago

vedantthapa commented 2 months ago

Since we've now completed our transition to data domain, deprecate temporary redirects for hopic-sdpac.data-donnes.phac-aspc.gc.ca.

Relates to https://github.com/PHACDataHub/cpho-phase2/pull/330.

vedantthapa commented 2 months ago

Looks good to me, but I don't know whether users are likely to have bookmarked the old domain, and whether it'd be a headache to try and tell the users they need to update their bookmarks.

Can you look at the logs and see if redirection are happening regularly? I assume there's logs for it, somewhere in GCP.

@Stephen-ONeil My apologies, I should've added some context in the PR description. Alex confirmed with the clients that we're good to kill the redirects.

Stephen-ONeil commented 2 months ago

Looks good to me, but I don't know whether users are likely to have bookmarked the old domain, and whether it'd be a headache to try and tell the users they need to update their bookmarks. Can you look at the logs and see if redirection are happening regularly? I assume there's logs for it, somewhere in GCP.

@Stephen-ONeil My apologies, I should've added some context in the PR description. Alex confirmed with the clients that we're good to kill the redirects.

Oh, oops, I'm out of touch! Haha