PHACDataHub / django-phac_aspc-helpers

Provides a series of helpers to provide a consistent experience accross PHAC-ASPC's Django based projects.
MIT License
0 stars 0 forks source link

feat: add more utils (excel, vanilla python stuff, custom model fields) #33

Closed AlexCLeduc closed 1 year ago

AlexCLeduc commented 1 year ago

I've completely changed the way tests are run, going through a dummy django app with some really basic models setup. It was necessary to test the model utils I added, and it'll be useful for future additions as well.

github-actions[bot] commented 1 year ago

Coverage

Coverage Report
FileStmtsMissCoverMissing
phac_aspc/django
   excel.py1482881%17–18, 49, 71, 81, 85, 119–121, 125–129, 132–133, 162, 170, 187–188, 214, 217, 219, 221, 224, 230, 236, 255–256, 263–264
   fields.py791680%46, 67–80, 102–105, 120–125, 128–132
phac_aspc/django/admin/decorators
   admin_decorators.py18289%37–38
phac_aspc/django/helpers/auth
   backend.py28280%2–36
   views.py442739%21, 26–29, 34–42, 47–99
phac_aspc/django/helpers/locale
   code.py8362%10, 13–14
phac_aspc/django/helpers/templatetags
   phac_aspc_auth.py7186%13
   phac_aspc_localization.py11464%11, 26–29
phac_aspc/django/helpers/views
   wet.py10640%12–19
phac_aspc/django/localization
   hooks.py660%2–16
phac_aspc/django/localization/decorators
   __init__.py220%4–6
   localization_decorators.py11110%4–46
phac_aspc/django/settings
   security.py251252%41–69
   utils.py54296%103, 154
TOTAL56114874% 

Tests Skipped Failures Errors Time
18 0 :zzz: 0 :x: 0 :fire: 2.014s :stopwatch:
AlexCLeduc commented 1 year ago

@Stephen-ONeil Happy to revisit using the config utils directly in the test app. I am a bit concerned we might run into things that break tests, like axes or security settings and I'd rather not spend time fighting tests right now. The priority is getting these excel utils in one of our projects and I'd like to stop copy/pasting them everywhere.