Update the Rad Lab Terraform modules - Githubissues

PHACDataHub / sci-portal

1 stars 0 forks source link

Update the Rad Lab Terraform modules #444

Closed seanpoulter-foci closed 3 months ago

seanpoulter-foci commented 3 months ago

This PR relates to #69 and #439.

Propsed Changes

In order to refactor and add features with confidence:

Add chainsaw tests for the Rad Lab modules to refactor with confidence
Update the chainsaw test for the Project to check status on remaining resources managed by Config Connector

In order of appearance in the diff:

Set the machine_type and trusted_users in the Rad Lab Terraform modules
Move namespace before name in Kubernetes manifests
Switch the Crossplane Terraform Workspace from vars to varmap
Fix the billing_account_id patch
Set the trusted_users and machine_type

Test Plan

Tested with chainsaw
Tested locally
- The properties are added to the claim: https://github.com/PHACDataHub/sci-portal-users/pull/29/files#diff-10135e87be5f63a30c2803c7ce75a1eb4588a2ee10b1e9bdd8a36e077b17dce3R28-R33
- Config Sync syncs
- The module deploys and the link to the Managed Workbooks works as expected https://backstage.alpha.phac-aspc.gc.ca/catalog/default/component/phx-01j006223h0