PHAREHUB / PHARE

💫 Parallel Hybrid Particle In Cell code with Adaptive mesh REfinement
https://phare.readthedocs.io
GNU General Public License v3.0
69 stars 25 forks source link

`SolverMHD` never used #728

Closed v01dXYZ closed 1 year ago

v01dXYZ commented 1 year ago

Summary

Details

Grepping for SolverMHD or "MHDSolver" shows the code for this solver is possibly not used (cf solver_mhd.hpp). The code in test_multiphysics_integrator doesn't cover this solver although we can found its name:

https://github.com/PHAREHUB/PHARE/blob/b1a9ec3804058865f16b6602bf5ba5d7633de212/tests/amr/multiphysics_integrator/test_multiphysics_integrator.cpp#L68-L72

but isInMHDRange always returns false:

https://github.com/PHAREHUB/PHARE/blob/b1a9ec3804058865f16b6602bf5ba5d7633de212/tests/amr/multiphysics_integrator/test_multiphysics_integrator.cpp#L10-L20

PhilipDeegan commented 1 year ago

MHD is planned, but not yet implemented.

v01dXYZ commented 1 year ago

Thanks for the answer. Good to know.