search

PHAREHUB / PHARE

💫 Parallel Hybrid Particle In Cell code with Adaptive mesh REfinement
https://phare.readthedocs.io
GNU General Public License v3.0
71 stars 24 forks source link

remove need for merged=True from user interface #849

Open nicolasaunai opened 5 months ago

nicolasaunai commented 5 months ago

Users should not have to worry about having to set merge=True or not when getting data with run.GetXXX(). Merged=True is currently there so that users may get an interpolator to get data wherever they want from the finest data in the hierarchy. They should be able to do that from a PatchHierarchy already. There's the __call__() in PatchHierarchy but I think it's kinda broken as it's (and was intended as is) not using an interpolator, but that probably is silly...

PhilipDeegan commented 2 months ago

is this still the case since recent PatchHierarchy updates?

nicolasaunai commented 2 months ago

yes, it's still there and I think it should not. The idea is that one should be able to do a slice in a PatchHierarchy representing a ScalarField or a VectorField anywhere and that should do the interpolation as needed without the need for the user to a priori decide whether to put merged=True or not. There should only be PatchHierarchies and that's it