Charge

[rochSmets]

Still on progress. This PR take into account the ion charge. I still need to replace the density functions by particleDensity or chargeDensity depending on the context...

Summary by CodeRabbit

• New Features

  • Enhanced support for particle density and charge density across various components of the application.
  • Added new parameters for charge density in multiple functions, improving data processing capabilities.

• Bug Fixes

  • Improved density calculation logic, increasing the accuracy of ion dynamics simulations.

• Documentation

  • Updated variable names for better clarity and consistency, enhancing code readability.

• Tests

  • Revised tests to ensure alignment with changes in density handling, maintaining comprehensive coverage of functionalities.

[coderabbitai[bot]]

Walkthrough

## Walkthrough This set of changes enhances the clarity and specificity of density-related computations across multiple components of the system. Key modifications involve renaming methods and variables related to particle density and charge density, thereby improving code interpretability and aligning terminology with their actual functions. These updates refine data processing and ensure that the simulation framework can handle more nuanced interactions involving both types of densities. ## Changes | File Path | Change Summary | |-----------------------------------------------------------------------------------------------|--------------------------------------------------------------------------------------------------------| | `src/amr/messengers/hybrid_hybrid_messenger_strategy.hpp`, `src/core/data/ions/ion_population/ion_population.hpp`, `src/core/data/ions/ions.hpp`, `src/core/numerics/interpolator/interpolator.hpp`, `src/core/numerics/ion_updater/ion_updater.hpp` | Replaced general density references with specific particle density and charge density, enhancing clarity across multiple classes and methods. | | `src/core/numerics/moments/moments.hpp`, `src/diagnostic/detail/types/fluid.hpp`, `src/python3/patch_level.hpp` | Renamed and restructured variables and methods to better align with the new density terminology, improving clarity and processing logic. | | `tests/core/numerics/ion_updater/test_updater.cpp` | Updated test variables and methods to reflect changes in density terminology, ensuring consistency and improved test clarity regarding charge density. | ## Possibly related PRs - **#859**: The changes in this PR involve significant refactoring related to particle density management, which aligns with the main PR's focus on enhancing particle density calculations and handling in the codebase. - **#866**: This PR's modifications to the `FluidDiagnostics` class and its handling of diagnostic parameters, including density, suggest a connection to the main PR's updates on density-related functionalities. - **#887**: While primarily focused on dependency management, the changes in this PR may indirectly relate to the overall structure and organization of the code, which could impact how density-related functionalities are integrated and maintained. ## Suggested labels `refactoring`, `python`, `pharesee`

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai generate interesting stats about this repository and render them as a table.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[nicolasaunai]

closed because of #891