PHAREHUB / PHARE

💫 Parallel Hybrid Particle In Cell code with Adaptive mesh REfinement
https://phare.readthedocs.io
GNU General Public License v3.0
69 stars 25 forks source link

job py #864

Open nicolasaunai opened 1 month ago

nicolasaunai commented 1 month ago

if not used and outdated maybe it should be deleted functional test are examples in some way, but mostly for python and not phareexe

PhilipDeegan commented 1 month ago

which file specifically?

find . -name job.py
./build/tests/amr/messengers/job.py
./build/tests/amr/multiphysics_integrator/job.py
./build/tests/initializer/job.py
./pyphare/pyphare/pharein/examples/job.py
./tests/initializer/job.py
PhilipDeegan commented 1 month ago

functional test are examples in some way, but mostly for python and not phareexe

functional tests with only a single simulation can be configured for phare-exe with minimal changes

mostly the following, which is what I've been doing locally

if __name__ == "__main__":
    main()
elif ph.PHARE_EXE:
    config()

and possible conditionally running startMPI() in python only if not running in phare-exe

PhilipDeegan commented 1 week ago

I guess it's ./pyphare/pyphare/pharein/examples/job.py

nicolasaunai commented 3 days ago

I think too

PhilipDeegan commented 3 days ago

I've deleted it as part of #888