nondeterministic?

[PhilipDeegan]

Summary by CodeRabbit

• Bug Fixes

  • Adjusted the behavior of the data unpacking process, which may enhance performance in parallel processing scenarios.
  • Removed the enforcement of deterministic unpack ordering in the scheduling process.

• New Features

  • Improved flexibility in data exchange across shared borders, potentially accommodating a wider range of operational contexts.
  • Simplified the implementation of the getPatternName method for better code readability.

[coderabbitai[bot]]

📝 Walkthrough

📝 Walkthrough

## Walkthrough The pull request introduces minor modifications to the `FieldFillPattern` class, including a formatting change to the `getPatternName` method and the addition of a comment regarding shared-node overwrite interior issues. Additionally, the `add` method of the `Communicator` class has been altered by removing the line that sets the deterministic unpack ordering flag for the schedule, allowing for a non-deterministic unpacking order. ## Changes | Files | Change Summary | |-----------------------------------------|--------------------------------------------------------------------------------------------------------| | `src/amr/data/field/field_variable_fill_pattern.hpp` | Updated the `getPatternName` method to a single-line implementation and added a comment regarding shared-node overwrite issues. | | `src/amr/messengers/communicator.hpp` | Removed the line `schedule->setDeterministicUnpackOrderingFlag(true);` from the `add` method of `Communicator`. |

---

📜 Recent review details

**Configuration used: .coderabbit.yaml** **Review profile: CHILL**

📥 Commits

Files that changed from the base of the PR and between e0ab3531f47e9cf0c3e4c689edbc41114c82f162 and bee7f6c4a131bc905f1bcbfa806ad3e26eefc5db.

📒 Files selected for processing (2)

* src/amr/data/field/field_variable_fill_pattern.hpp (2 hunks) * src/amr/messengers/communicator.hpp (0 hunks)

💤 Files not reviewed due to no reviewable changes (1)

* src/amr/messengers/communicator.hpp

✅ Files skipped from review due to trivial changes (1)

* src/amr/data/field/field_variable_fill_pattern.hpp

--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[PhilipDeegan]

we see that with this we change the mpi wait calls from "wait all" to "wait some", the some I guess being ranks of neighbouring patches rather than all ranks