PHAREHUB / PHARE

💫 Parallel Hybrid Particle In Cell code with Adaptive mesh REfinement
https://phare.readthedocs.io
GNU General Public License v3.0
71 stars 24 forks source link

hier comparae #910

Closed PhilipDeegan closed 1 month ago

PhilipDeegan commented 1 month ago

some of #888 isolated for roch

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago
📝 Walkthrough ## Walkthrough The changes in this pull request involve several modifications across various files in the `pyphare` library. Key updates include renaming and re-implementing floating-point comparison functions, deleting a simulation configuration file, enhancing error handling in user input functions, modifying error messages in the `LoadBalancer` class, and introducing new parameters and methods in hierarchy-related classes. Additionally, several classes related to data handling have been enhanced with new comparison methods and improved functionality. ## Changes | File Path | Change Summary | |---------------------------------------------|---------------------------------------------------------------------------------------------------------------------| | `pyphare/pyphare/core/phare_utilities.py` | Renamed `assert_fp_any_all_close` to `any_fp_tol`, which now returns tolerances. Added `fp_any_all_close` function for array comparison. Indentation fix in `is_fp32`. | | `pyphare/pyphare/pharein/examples/job.py` | Deleted file containing simulation configuration for a computational physics framework. | | `pyphare/pyphare/pharein/init.py` | Modified `get_user_inputs` to raise a `RuntimeError` if module import fails. | | `pyphare/pyphare/pharein/load_balancer.py`| Adjusted error messages in `LoadBalancer` class's `__post_init__` method from f-strings to string literals. | | `pyphare/pyphare/pharesee/hierarchy/fromh5.py` | Updated `get_all_available_quantities_from_h5` to include a new `hier` parameter for enhanced flexibility. | | `pyphare/pyphare/pharesee/hierarchy/hierarchy.py` | Added `__deepcopy__` method to `PatchHierarchy` class for deep copying instances. | | `pyphare/pyphare/pharesee/hierarchy/hierarchy_utils.py` | Updated `EqualityReport` class and modified `hierarchy_compare` for detailed mismatch reporting. New parameters added to `flat_finest_field` functions and introduced `single_patch_for_LO`. | | `pyphare/pyphare/pharesee/hierarchy/patchdata.py` | Enhanced `PatchData`, `FieldData`, and `ParticleData` classes with new comparison methods. | | `pyphare/pyphare/pharesee/particles.py` | Modified `Particles` class with size comparison in `__eq__`, added `__ne__`, and updated `select` method for box dimensionality checks. | ## Possibly related PRs - **#862**: The changes in this PR focus on assertions within the SAMRAI framework, which may relate to the floating-point comparisons and assertions modified in the main PR, particularly in how assertions are handled during different build types. - **#867**: This PR modifies the logic in the `single_patch_per_level_per_pop_from` function in `particles.py`, which may involve similar data handling and comparisons as the new `fp_any_all_close` function introduced in the main PR.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
PhilipDeegan commented 1 month ago

closes #864