PHI-base / PHI5_web_display

PHI5_web_display will allow to display PHI-Canto data
1 stars 0 forks source link

Disease name annotations do not show pathogen or host display names #47

Closed jseager7 closed 1 year ago

jseager7 commented 2 years ago

The Disease section does not show a display name for the metagenotype linked to the annotation. This is a similar bug to https://github.com/PHI-base/PHI5_web_display/issues/16, where the metagenotype display names were not displayed for gene-for-gene phenotypes.

Here is the current Disease section for ATR1 (PHIG:277) on PHI-base 5. The Additional information should not be grouped here, since each infects_tissue row should be for a different combination of pathogen and host strain.

image

Here is how the annotations appear in PHI-Canto, where each annotation has a different pathogen/host strain combination:

image

Shown below is an example of how the Disease name section should look, with the metagenotype display names shown. The structure matches that of the PHI Phenotype section.

image

Note that the 'Evidence' and 'Condition' fields will always be empty for the Disease section, so they could be hidden.

Also, I included the 'Filter by disease' search in the mockup, which would filter by PHIDO term, but this is not necessary for now if it would be a lot of work to implement.

jashobanta-mcpl commented 1 year ago

Fixed and deployed

jseager7 commented 1 year ago

@jashobanta-mcpl Thanks, but there's a problem with the new Disease display. The source annotations in PHI-Canto are on many different pathogen strains of H. arabidopsidis, but in the current display all the pathogen strains are the same (Emoy2).

image

In the images in my original comment, you can see that the following pathogen strains are used:

The host strains seem to be displayed correctly.

jashobanta-mcpl commented 1 year ago

Implemented .. Content re-indexing is going on . image

jseager7 commented 1 year ago

Looks like the Disease annotations are fixed now. Closing.