PHI-base / PHI5_web_display

PHI5_web_display will allow to display PHI-Canto data
1 stars 0 forks source link

Should we aggregate annotations by genotype and metagenotype? #48

Closed jseager7 closed 2 years ago

jseager7 commented 2 years ago

The PHI-base 5 gene pages currently aggregate annotations first by their ontology term, then by the biological feature that is annotated (e.g. genotype or metagenotype). This means that only the additional information section is not further aggregated.

However, the high-level terms are aggregated at the level of the ontology term, which could cause problems if the same ontology term is associated with contradictory high-level terms (e.g. reduced virulence and increased virulence).

We could remove the aggregation by biological feature, but this would likely be confusing for users since a lot of phenotypes would have a list of identical biological features, with the differences only visible on mouse-over (using the pop-up details) or once the annotations are expanded.

If we do choose to continue grouping by display name, then the high-level terms would need to be associated with the Additional information sections in order to prevent invalid combinations of high-level terms.

Note that I'm assuming the Entry Summary section will still aggregate all of the high level terms on the page, and no changes will be required there.

jseager7 commented 2 years ago

Based on the last meeting it seems we've decided to keep the current grouping and move the high level terms to the Additional information section. I'll open a new issue for this.