PHI-base / PHI5_web_display

PHI5_web_display will allow to display PHI-Canto data
1 stars 0 forks source link

Move high level terms to Additional information section #49

Closed jseager7 closed 1 year ago

jseager7 commented 2 years ago

The current annotation display has the high level terms for the annotation next to the display name of the metagenotype, or genotype:

image

However, this could lead to invalid combinations of high level terms – for example, 'reduced virulence' and 'increased virulence' – in cases where the virulence or pathogenicity is affected by data that is not grouped.

To prevent these invalid combinations, the high level terms need to be associated with each annotation, so the high level terms must be moved into the Additional information table, as another column:

image

Note that there may be cases where one annotation has more than one high level term. Currently, we have no examples of this, but since the JSON export has the high level terms as an array, the code should probably support displaying the high level terms as a comma delimited list.

Here's a mockup of what this would look like for an annotation with the high level terms 'Effector' and 'Reduced virulence':

image

Note that this change should not affect the display of high level terms in the Entry Summary section. Those should still be displayed in the same way.

jashobanta-mcpl commented 1 year ago

Fixed and deployed

jseager7 commented 1 year ago

Confirmed as fixed.

image