PHI-base / PHI5_web_display

PHI5_web_display will allow to display PHI-Canto data
1 stars 0 forks source link

Wrong publication reference in 'How to cite us' section #60

Closed jseager7 closed 1 year ago

jseager7 commented 1 year ago

On the homepage, the 'How to cite us' link and the DOI for the latest NAR publication are both broken. Also, the DOI is not displayed and the publication date is wrong.

image

This is a regression from issue #43, where it was requested that the section appear as follows:

How to cite us: Urban, M. et al (2022). NAR doi: 10.1093/nar/gkab1037

The URL for both links ends in the following path:

phibase-v3/null

So the fields are probably being populated with a null value somehow. This could be related to the strapi content not being integrated correctly.

jashobanta-mcpl commented 1 year ago

It was an issue from the headless CMS connection end. Fixed and deployed . Same as #61

jseager7 commented 1 year ago

@jashobanta-mcpl I'm still seeing the broken links on the latest version of the website (v3).

image

Maybe the change didn't deploy correctly?

jseager7 commented 1 year ago

@jashobanta-mcpl Never mind, the problem with the links was because of my browser cache not having refreshed.

However, the date on the publication reference is still incorrect. It says 2019, but the publication date of the DOI is 2022.

Here's what I'd expect to see:

image

Note also that "et al" should have a full stop (period) after the "al" (et al.)

jashobanta-mcpl commented 1 year ago

It's fixed .

jseager7 commented 1 year ago

@jashobanta-mcpl We still need the text on the citation updated to have 2022 as the year (instead of 2019), and "et al" needs to end with a full stop, as in "et al." See the image below:

image

Note that my caching issue was only to do with the links: the problem with the citation text still exists after refreshing the cache.

jseager7 commented 1 year ago

This is fixed now.

image